[9.x] Improve missing attributes functionality #44845
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an improvement for the recently merged #44283.
The following changes are included:
HasAttributes
trait for a custom class. However, the following piece of code makes a call to the properties$this->exists
and$this->wasRecentlyCreated
first which did not exist in my implementation, therefore throwing an "Undefined property" ErrorException:framework/src/Illuminate/Database/Eloquent/Concerns/HasAttributes.php
Lines 465 to 478 in 0702f55
That if-statement has now been reordered to first call the
static::preventsAccessingMissingAttributes()
, and since this isfalse
by default the code will work correctly.HasAttributes
.