-
Notifications
You must be signed in to change notification settings - Fork 11.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[9.x] Add source file to Collection's dd method output #44793
Conversation
@AhrimFakhriy you think you can create a static property of the trait, that key value map with (name => traceKey), so we can extend this work to other files? |
@nunomaduro will this suffice? |
*/ | ||
protected static $traceNames = [ | ||
'symfony/var-dumper/Resources/functions/dump.php' => 1, | ||
'Illuminate/Collections/Traits/EnumeratesValues.php' => 4, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This changes work on Windows due the different separator?
@AhrimFakhriy Can you check my question please? I will move this pull request out of draft, once I think is ready. |
@nunomaduro Im sorry, I didnt know I'm not supposed to click on the "Ready for review" button myself. |
This pull request further extends #44211 by @nunomaduro to work on
Collection
by adding the source file/line to thedd
output of theCollection
class method.After using the improved
dd
, I found it odd thatCollection
classdd
method did not give the same output as the current improveddd
function. The workaround was to wrap the collection variable withdd
instead of using the built indd
method ofCollection
class.