[9.x] Add integration test for PR #42130 #42140
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cessing non-cached attribute #42130
|
Hmm, in this case I may revert the original PR in case it causes other problems. I do note that the documentation on appending uses snake case as well, since attributes are usually referenced in snake case. |
|
Oh, my bad! Thank you for catching that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding integration test for #42130
@taylorotwell When writing the test, I found out its only for attributes using camel case and an append specified. The fix still seems to work great, but maybe this was a bandaid over a deeper underlying problem?