-
Notifications
You must be signed in to change notification settings - Fork 11.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[9.x] Add getAllTables support for SQLite and SQLServer schema builders #41896
[9.x] Add getAllTables support for SQLite and SQLServer schema builders #41896
Conversation
tests/Integration/Database/MySql/DatabaseMySqlSchemaBuilderAlterTableWithEnumTest.php
Outdated
Show resolved
Hide resolved
tests/Integration/Database/SqlServer/DatabaseSqlServerSchemaBuilderTest.php
Outdated
Show resolved
Hide resolved
tests/Integration/Database/Sqlite/DatabaseSqliteSchemaBuilderTest.php
Outdated
Show resolved
Hide resolved
eof lines have been fixed. Apologies. |
@Sourcefli Please fix this failing test and explain why it is failing: https://github.com/laravel/framework/runs/6003485596?check_suite_focus=true Will give it about 24 - 48 hours to be fixed before I revert this PR. Thanks. |
No problem, thanks @taylorotwell. Strange that in the test theres a count of 7 though, being that only up to 3 tables - each with no more than 3 columns in their schema - is being used within each test... and these tests were passing when run by themselves or within their respective file's tests. My suspicion is that there's leftover tables from previous tests that ran. |
We need to revert this asap if we can't find a solution now. Every single PR to 9.x is currently failing because of this. |
I found that the I was using the phpunit.xml.dist file to run these tests locally, yet came to realize that this file was ignored when running the tests using the command above. I have updated the |
@Sourcefli can you PR? |
Ok, I've got up the fix to this PR, #41984. I was keep pushing up changes because I had had passing tests locally, so I could only see if/when it failed after I'd made some edits then pushed again. Curious to know how you guys typically go about setting up multiple db connection envs when working with this test suite, which would 1) stay in sync with the envs used while testing different connections on Github, and 2) be ignored when pushing. I ended up jumping into the orchestra vendor folder for this reason, though not sure if that's the ideal solution. Thanks for your assistance guys 👍 |
This PR adds support for calling
\Illuminate\Support\Facades\Schema::getAllTables()
on SQLite and SQLServer connections.I'm returning the
name
andtype
columns to maintain consistency with what's already being returned when using the MySQL or Postgres connections.P.S.
This being my 1st Laravel contribution, please go easy on me if I've done something incorrectly here. 😉