[9.x] Fix Collection::implode() string argument
#41468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
collect(['foo', 'bar'])->implode('_') should be 'foo-bar' but it
instead attempts to call translator helper _().
For callable only support Closure, an invokable class, or a
[class, 'method'] array pair.
|
Is this a typo mistake? You mean collect(['foo', 'bar'])->implode('_') should be 'foo_bar', don't you? |
This was referenced Mar 14, 2022
driesvints
approved these changes
Mar 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #41466 introduced by #41405
collect(['foo', 'bar'])->implode('_')should be'foo_bar'but it instead attempts to call translation helper_().It needs the same fix as #41424
For a callable arg, don't support global helpers. Only allow a Closure, invokable class, or [$object, 'method'] array pair.