Skip to content

[8.x] Explicitly set unit of sleep of retry function #36810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
taylorotwell merged 2 commits into from
Mar 30, 2021
Merged

[8.x] Explicitly set unit of sleep of retry function #36810

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eb71da3
Explicitly set unit of sleep or retry functon
mrsimonbennett Mar 30, 2021
ff35d85
Update helpers.php
taylorotwell Mar 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/Illuminate/Support/helpers.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,13 +216,13 @@ function preg_replace_array($pattern, array $replacements, $subject)
*
* @param int $times
* @param callable $callback
* @param int $sleep
* @param int $sleepMilliseconds
* @param callable|null $when
* @return mixed
*
* @throws \Exception
*/
function retry($times, callable $callback, $sleep = 0, $when = null)
function retry($times, callable $callback, $sleepMilliseconds = 0, $when = null)
{
$attempts = 0;

Expand All @@ -237,8 +237,8 @@ function retry($times, callable $callback, $sleep = 0, $when = null)
throw $e;
}

if ($sleep) {
usleep($sleep * 1000);
if ($sleepMilliseconds) {
usleep($sleepMilliseconds * 1000);
}

goto beginning;
Expand Down