-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[9.x] Update pusher-php-server to 5.x #36344
Conversation
Why not support both version 4 and 5, and larger Laravel 8? |
Raised issue here: pusher/pusher-http-php#283 |
@Koozza did you actually test this and prove it was working on your end? |
@GrahamCampbell I'd love to support 4.x as well but I don't know how to achieve that. 5.x has a changed trigger signature and in additon a changed response. @taylorotwell I did test this after appling a fix to the 5.x branch of the php-pusher package. I also created a PR for that package solving the issue you've mentioned above: pusher/pusher-http-php#281 |
Issue is fixed in pusher/pusher-http-php#281, which has been released in v5.0.1. |
I brought this change into 8.x and supported both 4 and 5. |
Thanks! |
I'm still getting this error after updating to pusher
Reverting to |
@vesper8 are you by any chance connecting to a laravel-pusher (beyondcode) server? |
@Koozza yes I am |
I opened a PR there as well: beyondcode/laravel-websockets#698 The problemen is that their HTTP response doesn't matches Pushers. |
@Koozza thank you! Will subscribe to that and keep an eye out for a new version |
This is my first PR for laravel, so I'm not sure if I did this right. This PR allows the usage of pusher PHP server 5.x. I don't think it's backwards compatible with 4.x
Made after issue: #36339