Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] Dont merge middleware from method and property #31301

Merged
merged 1 commit into from
Jan 30, 2020

Conversation

themsaid
Copy link
Member

Since already merge middleware from the method and from the property when sending a job through the pipeline, we don't need to make the middleware() method return the values of the middleware property.

This leads to middleware duplication in case there are middleware in the property but the method wasn't added to the job, as reported in #31192.

@taylorotwell taylorotwell merged commit 0fa8ec7 into laravel:6.x Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants