Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.x] Deprecate sendNow and remove unneeded check #30999

Merged
merged 3 commits into from
Jan 2, 2020
Merged

[6.x] Deprecate sendNow and remove unneeded check #30999

merged 3 commits into from
Jan 2, 2020

Conversation

themsaid
Copy link
Member

@themsaid themsaid commented Jan 2, 2020

This PR removes PendingMail::sendNow since it won't actually send the mail now if the mailable implements ShouldQueue. It works same as send.

It Also removes the ShouldQueue check from PendingMail::send since the check will happen in Mailer::sendMailable anyway.

Finally, it removes the $mailable->delay check since it'll be checked in Mailable::queue anyway.

GrahamCampbell
GrahamCampbell approved these changes Jan 2, 2020
View reviewed changes
Copy link
Member

@GrahamCampbell GrahamCampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. 👍

@taylorotwell taylorotwell merged commit 0b748bc into laravel:6.x Jan 2, 2020
@vigneshgurusamy vigneshgurusamy mentioned this pull request Jan 8, 2020
Closed
@nanaya nanaya mentioned this pull request Jun 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrahamCampbell GrahamCampbell GrahamCampbell approved these changes

@driesvints driesvints driesvints approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@themsaid @driesvints @GrahamCampbell @taylorotwell