[5.8] Fix qualified UPDATED_AT timestamps - #26997
Merged
Merged
Conversation
koenhoeijmakers
approved these changes
Dec 30, 2018
Contributor
|
ETA for the next patch? |
Contributor
|
Hmm, what for? This went straight into 5.8 which is already released? |
Contributor
|
My bad. I feel so stupid for not seeing that the PR got published in December 2018. So the MongoDB issues should be fixed within the MongoDB package. |
This was referenced Sep 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#26031 qualified
UPDATED_ATtimestamps to fix ambiguity issues.This doesn't work properly when the attributes already contain an
updated_atvalue:In this case,
Builder::addUpdatedAtColumn()returns an array with two separateupdated_atvalues:We have to merge the attributes first and then qualify the column by replacing the array key.
Fixes #26995.