Skip to content

[5.5] Remove "select" bindings from MySQL delete statments. - #22285

Merged
taylorotwell merged 2 commits into
laravel:5.5from
themsaid:pr/22816
Dec 3, 2017
Merged

[5.5] Remove "select" bindings from MySQL delete statments.#22285
taylorotwell merged 2 commits into
laravel:5.5from
themsaid:pr/22816

Conversation

@themsaid

@themsaid themsaid commented Dec 2, 2017

Copy link
Copy Markdown
Member

This PR will ensure "select" bindings are removed and join arguments are put in the correct order:

delete `users` from `users` inner join `names` on `names`.`user_id` = `users`.`id` and `names`.`user_id` = ? where `users`.`id` = ?

Here "join" bindings comes first and then "where" bindings, select bindings aren't needed in the query and thus removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants