Skip to content

[5.4] Adds ability to eager load counts via property #19154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
taylorotwell merged 3 commits into from
May 11, 2017
Merged

[5.4] Adds ability to eager load counts via property #19154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d040f73
Adds ability to eager load counts via property
regularlabs May 11, 2017
9010f14
Update QueriesRelationships.php
regularlabs May 11, 2017
c4f589e
Update QueriesRelationships.php
regularlabs May 11, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/Illuminate/Database/Eloquent/Concerns/QueriesRelationships.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,10 @@ public function whereDoesntHave($relation, Closure $callback = null)
*/
public function withCount($relations)
{
if (empty($relations)) {
return $this;
}

if (is_null($this->query->columns)) {
$this->query->select([$this->query->from.'.*']);
}
Expand Down
9 changes: 8 additions & 1 deletion src/Illuminate/Database/Eloquent/Model.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,13 @@ abstract class Model implements ArrayAccess, Arrayable, Jsonable, JsonSerializab
*/
protected $with = [];

/**
* The relations to eager load the count on every query.
*
* @var array
*/
protected $withCount = [];

/**
* The number of models to return for pagination.
*
Expand Down Expand Up @@ -809,7 +816,7 @@ public function newQueryWithoutScopes()
// Once we have the query builders, we will set the model instances so the
// builder can easily access any information it may need from the model
// while it is constructing and executing various queries against it.
return $builder->setModel($this)->with($this->with);
return $builder->setModel($this)->with($this->with)->withCount($this->withCount);
}

/**
Expand Down