Fixes confirm default value (#43334)

laravel · Jul 21, 2022 · a324e92 · a324e92
1 parent 3877ff9
commit a324e92
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 2 deletions.
diff --git a/src/Illuminate/Console/ConfirmableTrait.php b/src/Illuminate/Console/ConfirmableTrait.php
@@ -29,6 +29,8 @@ public function confirmToProceed($warning = 'Application In Production', $callba
             $confirmed = $this->components->confirm('Do you really wish to run this command?');
 
             if (! $confirmed) {
+                $this->newLine();
+
                 $this->components->warn('Command canceled.');
 
                 return false;

diff --git a/src/Illuminate/Console/View/Components/Confirm.php b/src/Illuminate/Console/View/Components/Confirm.php
@@ -11,7 +11,7 @@ class Confirm extends Component
      * @param  bool  $default
      * @return bool
      */
-    public function render($question, $default = true)
+    public function render($question, $default = false)
     {
         return $this->usingQuestionHelper(
             fn () => $this->output->confirm($question, $default),

diff --git a/tests/Console/View/ComponentsTest.php b/tests/Console/View/ComponentsTest.php
@@ -66,12 +66,20 @@ public function testConfirm()
         $output = m::mock(OutputStyle::class);
 
         $output->shouldReceive('confirm')
-               ->with('Question?', true)
+               ->with('Question?', false)
                ->once()
                ->andReturnTrue();
 
         $result = with(new Components\Confirm($output))->render('Question?');
         $this->assertTrue($result);
+
+        $output->shouldReceive('confirm')
+               ->with('Question?', true)
+               ->once()
+               ->andReturnTrue();
+
+        $result = with(new Components\Confirm($output))->render('Question?', true);
+        $this->assertTrue($result);
     }
 
     public function testChoice()