fix(Process): Convert command to array format

[Quynh-Nguyen]

When upgrade dependency symfony/process to version ^5.0

We will got this error:

Fatal error: Uncaught TypeError: Argument 1 passed to Symfony\Component\Process\Process::__construct() must be of the type array, string given, called in /root/.composer/vendor/laravel/envoy/src/RemoteProcessor.php on line 62 and defined in /root/.composer/vendor/symfony/process/Process.php:140

So this pull request for resolve this issue.

I was tested on my local.

[driesvints]

Released v1.6.3 with this.

[crynobone]

https://symfony.com/doc/current/components/process.html#using-a-prepared-command-line

I think it would be more appropriate to use Process::fromShellCommandline()

[Quynh-Nguyen]

@crynobone
Yes that's also one option.
But I don't want to break the source code structure too much.

[crynobone]

@Quynh-Nguyen I just happen to have faced with the same issue on my project using symfony/process and converting it to array doesn't work.

use Symfony\Component\Process\Process;

require "vendor/autoload.php";

$command = "/Applications/Google\ Chrome.app/Contents/MacOS/Google\ Chrome --version";
$script = explode(' ', $command);
$process = new Process($script);
$process->mustRun();

PHP Fatal error:  Uncaught Symfony\Component\Process\Exception\ProcessFailedException: The command "'/Applications/Google\' 'Chrome.app/Contents/MacOS/Google\' 'Chrome' '--version'" failed.

Exit Code: 126(Invoked command cannot execute)

Working directory: /Users/miki/Projects/orchestra/dusk-updater

Output:
================


Error Output:
================
sh: /Applications/Google\: No such file or directory
sh: line 0: exec: /Applications/Google\: cannot execute: No such file or directory
 in /Users/miki/Projects/orchestra/dusk-updater/vendor/symfony/process/Process.php:250
Stack trace:
#0 /Users/miki/Projects/orchestra/dusk-updater/example.php(10): Symfony\Component\Process\Process->mustRun()
#1 {main}
  thrown in /Users/miki/Projects/orchestra/dusk-updater/vendor/symfony/process/Process.php on line 250

Fatal error: Uncaught Symfony\Component\Process\Exception\ProcessFailedException: The command "'/Applications/Google\' 'Chrome.app/Contents/MacOS/Google\' 'Chrome' '--version'" failed.

Exit Code: 126(Invoked command cannot execute)

Working directory: /Users/miki/Projects/orchestra/dusk-updater

Output:
================


Error Output:
================
sh: /Applications/Google\: No such file or directory
sh: line 0: exec: /Applications/Google\: cannot execute: No such file or directory
 in /Users/miki/Projects/orchestra/dusk-updater/vendor/symfony/process/Process.php:250
Stack trace:
#0 /Users/miki/Projects/orchestra/dusk-updater/example.php(10): Symfony\Component\Process\Process->mustRun()
#1 {main}
  thrown in /Users/miki/Projects/orchestra/dusk-updater/vendor/symfony/process/Process.php on line 250

---

I only manage to solve the issue by changing it to Process::fromShellCommandline(). So I don't know how extensive the use of process in envoy and whether or not anything similar needed.

[Quynh-Nguyen]

@crynobone
This is the reason:

Google\ Chrome.app

[driesvints]

Urgh, I'll get that fixed in a bit.

[Quynh-Nguyen]

@driesvints
Can I create new pull request for resolve the case run script on localhost case?

[crynobone]

$process = new Process(["/Applications/Google\ Chrome.app/Contents/MacOS/Google\ Chrome", "--version"]);
$process->mustRun();

Trying to be smart and do it manually also return the same error.

PHP Fatal error:  Uncaught Symfony\Component\Process\Exception\ProcessFailedException: The command "'/Applications/Google\ Chrome.app/Contents/MacOS/Google\ Chrome' '--version'" failed.

Exit Code: 126(Invoked command cannot execute)

Working directory: /Users/miki/Projects/orchestra/dusk-updater

Output:
================


Error Output:
================
sh: /Applications/Google\ Chrome.app/Contents/MacOS/Google\ Chrome: No such file or directory
sh: line 0: exec: /Applications/Google\ Chrome.app/Contents/MacOS/Google\ Chrome: cannot execute: No such file or directory
 in /Users/miki/Projects/orchestra/dusk-updater/vendor/symfony/process/Process.php:250
Stack trace:
#0 /Users/miki/Projects/orchestra/dusk-updater/example.php(8): Symfony\Component\Process\Process->mustRun()
#1 {main}
  thrown in /Users/miki/Projects/orchestra/dusk-updater/vendor/symfony/process/Process.php on line 250

Fatal error: Uncaught Symfony\Component\Process\Exception\ProcessFailedException: The command "'/Applications/Google\ Chrome.app/Contents/MacOS/Google\ Chrome' '--version'" failed.

Exit Code: 126(Invoked command cannot execute)

Working directory: /Users/miki/Projects/orchestra/dusk-updater

Output:
================


Error Output:
================
sh: /Applications/Google\ Chrome.app/Contents/MacOS/Google\ Chrome: No such file or directory
sh: line 0: exec: /Applications/Google\ Chrome.app/Contents/MacOS/Google\ Chrome: cannot execute: No such file or directory
 in /Users/miki/Projects/orchestra/dusk-updater/vendor/symfony/process/Process.php:250
Stack trace:
#0 /Users/miki/Projects/orchestra/dusk-updater/example.php(8): Symfony\Component\Process\Process->mustRun()
#1 {main}
  thrown in /Users/miki/Projects/orchestra/dusk-updater/vendor/symfony/process/Process.php on line 250

[driesvints]

@crynobone @Quynh-Nguyen I released v1.6.4 which used fromShellCommandline instead. Can you try that one?

[crynobone]

[driesvints]

@crynobone thanks for verifying 👍