Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix line splitting when reading story code #168

Merged
merged 2 commits into from
Oct 25, 2019
Merged

Fix line splitting when reading story code #168

merged 2 commits into from
Oct 25, 2019

Conversation

colorgreen
Copy link
Contributor

While running envoy from windows command line I had problem with story. The same issue someone described here:
https://stackoverflow.com/questions/58359904/laravel-envoy-taskcontainer-line-330-probleme

And problem with exploding PHP_EOL has been known for a long time. Examples:
https://eidson.info/post/php_eol_is_broken
vlucas/phpdotenv#3

This is small fix for that, it is crossplatform

@taylorotwell taylorotwell merged commit eb4b243 into laravel:master Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants