Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] Change to openswoole #7449

Merged
merged 2 commits into from
Nov 22, 2021
Merged

[8.x] Change to openswoole #7449

merged 2 commits into from
Nov 22, 2021

Conversation

mohprilaksono
Copy link
Contributor

@taylorotwell
Copy link
Member

I have no idea what all this open Swoole vs Swoole stuff is about tbh. Why should I choose one or the other?

@mohprilaksono
Copy link
Contributor Author

@taylorotwell actually openswoole is a fork of the previous swoole extension since version v4.7.1, you can read about it here:
https://www.getrevue.co/profile/openswoole/issues/we-are-now-open-swoole-812526

@taylorotwell
Copy link
Member

Why should I use this instead of swoole?

@mohprilaksono
Copy link
Contributor Author

mohprilaksono commented Nov 22, 2021

The official documentation said that only support openswoole and only suitable for swoole extension version 4.7.1. also, in the installation process is using openswoole instead of swoole.
And recently Laravel octane support both swoole and openswoole extension,

laravel/octane#407

Maybe I should change this PR to support both? Like "pecl install swoole or pecl install openswoole"?

@taylorotwell taylorotwell merged commit 9a3344a into laravel:8.x Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants