Publishing to users #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very much urgent! Please merge the push notifications for users.. Need it the most.. |
|
Thank you for this @andreaselia ! I'm also waiting anxiously for this to be merged. |
Contributor
Author
|
I think maybe @themsaid or @freekmurze could help, although I'm not entirely sure who the main maintainer of this repo is. |
Member
|
@andreaselia Can you confirm this is ready to be merged? |
Contributor
Author
|
@atymic Yup, ready to be merged - thank you! |
andreaselia
changed the title
atymic
approved these changes
Dec 23, 2020
Member
atymic
left a comment
atymic
left a comment
There was a problem hiding this comment.
Looks good, couple of minor bits
Contributor
Author
|
@atymic changes complete, thanks for the feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! 👋
This is related to issue #51, I thought I'd have a go at mocking up what the functionality could be look whilst also being backwards compatible. The
publishToInterestsfunctionality works as it did before (no changes required).I guess
$beamsClient->deleteUser($userId)and$beamsClient->generateToken($userId)functionalities would require you to consume another instance of the client.Any feedback/pointers would be greatly appreciated.