Skip to content

Conversation

@Stalinko
Copy link

@Stalinko Stalinko commented Jun 4, 2020

Pusher Beams allows passing meta data along with message parameters: https://pusher.com/docs/beams/guides/publishing-to-multiple-devices#adding-metadata-to-a-notification

I'm using that in my project and decided to format as a handy API in PusherMessage class.
Tests added.
Also added .idea folder into .gitignore. It's created by PHPStorm.

@Stalinko
Copy link
Author

Stalinko commented Jun 4, 2020

I see the style checker didn't like !empty() construction without space after exclamation (who writes a space after exclamation? 😱) .
If necessary I can fix. How to make it better? Make another commit and create a new PR or how?

@andreaselia
Copy link
Contributor

andreaselia commented Dec 23, 2020

@Stalinko I'd probably recommend fixing the space as the entire repo follows the styleci set rules.

Also, the conflict will likely need fixing.

Copy link
Member

@atymic atymic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll fix the style issues.

@atymic
Copy link
Member

atymic commented Dec 23, 2020

Could you resolve the conflicts please?

@Stalinko
Copy link
Author

Stalinko commented Oct 7, 2021

I've resolved the conflicts.
Sorry I'm not familiar with the process of contributing to Open Source. Any advice how to finalize it properly would be appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants