Target external user IDs #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Can you add a test for this please? |
Contributor
Author
|
@LKaemmerling I've added the test, thanks for the feedback. |
Collaborator
|
LGTM @Lloople what do you think? |
LKaemmerling
approved these changes
Jan 2, 2019
Collaborator
|
Looks good. Is there a way to test the content of the |
Collaborator
|
@Lloople the payload is already tested in https://github.com/laravel-notification-channels/onesignal/pull/86/files#diff-6e36f1a1becd7049f27f18c6212bced0R255 or am i wrong? |
Collaborator
|
You’re right! I didn’t saw it from the phone 😅 |
Lloople
approved these changes
Jan 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small change that allows you to send notifications to users by specifying an external user ID.
See the OneSignal docs under 'include_external_user_ids' for all the details.