Add payload factory#50
Merged
LKaemmerling merged 4 commits intoFeb 28, 2018
Merged
Conversation
LKaemmerling
approved these changes
Feb 28, 2018
Collaborator
|
Thank you! i will merge it and test it some days on a production environment. If all is good we will release it in this week as 1.2.0. Thank you! |
Contributor
Author
|
No probs happy to help out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added a basic factory to run through the payload logic. This will keep all the logic around what the notification is targeting in one place e.g. emails, player ids, and soon tags + whatever else may be added in the future.
I've added the
payloadmethod to the channel class so devs can still easily extend the channel and add future payload functionality that might not yet be implemented - rather than introducing Interfaces etc for the factory. Keeping it simpler.