Support Auto-Discovery

[Omranic]

https://medium.com/@taylorotwell/package-auto-discovery-in-laravel-5-5-ea9e3ab20518

[igorsantos07]

Actually, I see this PR doesn't even make sense and caused a breaking bug (as reported at #305). Would the OP/upvoters help me here?

AFAIK, the ServiceProvider and the Facade on this package are of no use. I don't see further mentions of these on the package source, and I don't recall ever installing these.

cc @spyp @lloricode @Juddling @Omranic

[Juddling]

@igorsantos07 The service provider looks redundant to me, people could be using the Facade, so I'd be inclined to not remove that.

But I don't know this package very well.

[igorsantos07]

Yeah, I guess people might be using, indeed. However, they're by their own, as that's not suggested by the docs, nor needed for any feature. The facade would only cause confusion, as it serves no purpose at all. Thus, I don't think this possibly breaking change is worth a major version bump. It seems like an ancient feature that became an internal implementation detail. If there's indeed people having trouble because of 3.5, I'll revert it in 3.5.1 as a deprecation warning, and launch 4.0 🤷🏼‍♂️

…

On Tue, Oct 9, 2018, 09:22 James Judd, ***@***.***> wrote: @igorsantos07 <https://github.com/igorsantos07> The service provider looks redundant to me, people could be using the Facade, so I'd be inclined to not remove that. But I don't know this package very well. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#305 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAgfS5rP-6WQWV-t75bCJH9bI1G7e6iEks5ujJUMgaJpZM4OBFee> .