This repository has been archived by the owner on Jul 16, 2023. It is now read-only.
Updated illuminate dependencies for ~5.0 #261
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Status on this? |
|
As this would make new releases incompatible with Laravel 4, there's a question that needs to be answered: is the current codebase REALLY compatible with Laravel 5? This needs to be tested before releasing it - or, maybe, we can release as a new major version. |
| @@ -25,9 +25,9 @@ | |||
| }, | |||
| "require": { | |||
| "php": ">=5.3.0", | |||
There was a problem hiding this comment.
Include here PHP 5.4 as well. That's a new requirement for Laravel 5.
|
@igorsantos07 Any plans when you are going to support Laravel 5? Happy to help .... |
|
@davincho I was going to accept this PR into another branch, for testing, but the author didn't replied back my comments. As I'm probably going to need Ardent soon, I might as well tackle this myself in the following weeks, tho. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please merge this into main repo. This ensures compatibility for Laravel 5.
Currently L5
composer updatefails.