This repository has been archived by the owner on Jul 16, 2023. It is now read-only.
In Ardent\belongsTo function $relation was being over-written with the calling function name. #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cked this up when trying to associate a model relationship dynamically via $model->belongsTo($related, $foreignKey, $otherKey, $relation)->associate($relationModel);
|
This is legit! However, please wrap all the backtrace call in your |
|
Ah ok, makes sense... have done so.. |
|
thank you! congrats on your first PR man :) haha |
igorsantos07
added a commit
that referenced
this pull request
May 10, 2015
In `Ardent\belongsTo` $relation was being over-written with the calling function name
|
woohoo! haha! thanks. Was about time.. have been using different open source libraries but haven't had the privilege of contributing yet.. to many more :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First time open-source contributor here.. Have been using Ardent for a while, and it's really great! Thank you!
In Ardent\belongsTo function $relation was being over-written with the calling function name. I picked this up when trying to associate a model relationship dynamically via $model->belongsTo($related, $foreignKey, $otherKey, $relation)->associate($relationModel);