This repository has been archived by the owner on Jul 16, 2023. It is now read-only.
Use parent newQuery to get a Builder object. #245
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe it should be fixed in |
ghost
mentioned this pull request
This solves an issue where global scopes were not being applied.
|
Solves for me too. |
|
Part of this seems related to #227, but you tackle the issue through a different approach. However, this seems to change the way some Ardent methods works - since it will aparrently stop using |
| @@ -893,11 +893,6 @@ public function newQuery($excludeDeleted = true) { | |||
| // while it is constructing and executing various queries against it. | |||
| $builder->setModel($this)->with($this->with); | |||
|
|
|||
| if ($excludeDeleted and $this->softDelete) | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves an issue where global scopes were not being applied.
I guess in theory it also solves other issues which are fixed upstreams in
Eloquentbut this is the one I know of for now.