This repository has been archived by the owner on Jul 16, 2023. It is now read-only.
Fix ->validationErrors->count() when the object is null #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if ($this->validationErrors->count() > 0) { | ||
| if($this->validationErrors === null){ | ||
| $this->validationErrors = new MessageBag; | ||
| }elseif($this->validationErrors->count() > 0) { |
There was a problem hiding this comment.
I think it would look cleaner if these two conditions were merged.
$this->validationErrors = new MessageBag; is executed in both cases anyway.
There was a problem hiding this comment.
Please, fix spacing. Would be nice if you follow PSR-2: http://www.php-fig.org/psr/psr-2/#5.1.-if,-elseif,-else
|
@wemersonrv, please take a look at the two notes in the diff :) |
igorsantos07
added a commit
that referenced
this pull request
May 10, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi... in the src/LaravelBook/Ardent/Ardent.php line 541 i've found an issue: The
$this->validationErrors->count()causes an error becausevalidationErrorsis null and does not retrive thecount()method.See this Screenshot
Then a single check if it's null, solve it... I do know how the object is null in my case, but here is my suggestion in this pull request.
Sorry about my poor english!