-
Notifications
You must be signed in to change notification settings - Fork 211
Conversation
hasSessionStore method has been removed. In its place hasSession() method shold be used. Reference: laravel/framework@328e6cf
+1 |
2 similar comments
+1 |
+1 |
+1 thx for this nice package |
+1 |
5 similar comments
+1 |
+1 |
+1 |
+1 |
+1 |
+100 |
+1 |
1 similar comment
+1 |
+1 In the meantime I've just adjusted my composer.json to lock my app on Laravel 4.1.16
|
+1 2.4.x doesn't seem to work for me. |
+1 |
3 similar comments
+1 |
+1 |
+1 |
See #154 |
+1 |
2.4.* doesn't fix it. |
👍 |
wow, it's already 12 days. hope this commit will be evaluated soon. 👍 |
+1 |
+1!! |
+1 |
Any other contributors able to merge this and release? I'd like to be able to use the most recent Laravel with it. Currently I have to use 4.1.16 if I want to use Ardent without changing it myself. @laravelbook |
@laravelbook this more than a few months without activities on github. |
@vinicius73 i think it's time for someone more interested in doing some free work to create a fork and i pledge to contribute as much as my time allows :) |
I mean the last update is only a month ago which isn't too bad to be honest. But a fork is always an option in the meantime. |
i guess we'll just wait and see ,and edit the source code manually until 2014-01-30 Ryan Nielson [email protected]:
Mouhsine Bakhich * ,Developper Trans Gulf For Information Technology |
Sorry boys, but first of all, laravelbook does not take care of this Second, I've been busy with my paid job and couldn't even stop at home to Third, you don't need a fork. You can just learn to use Composer the right I'm going to merge this tonight or tomorrow. Please stop complaining or Finally, if there's anyone interested in entering the Ardent team, we can Igor Santos
|
In short, make a fork and change you without bothering to contribute. |
@igorsantos07 I appreciate your work on Ardent but 6 days ago you said you were going to merge this. It is a one line change and very low risk. Please merge. |
I'm just saying that accepting a PR is not the only way to use the code, if
|
I don't get what is going on, we're talking about merging one small line of code. Nothing fancy, and this would be greatly appreciated by the quite large amount of people who uses your code. I took a second, forked your repo, fixed that line and simply added this to my "require": {
"laravelbook/ardent": "master"
},
"repositories": [{
"url": "https://github.com/tbergeron/ardent.git",
"type": "git"
}], In a minute, Ardent was up and running. Why all of this? I mean all you have is click on a button. Hope this temporarily help someone. |
Thanks for creating a temporary solution. I'd love to help on the project, and I've already contacted Igor a few days back. I haven't heard back yet, but I'm hoping I'm the person he's referring to in his last comment. |
@tbergeron the short explanation is: I haven't touched my computer in ages, and I can't do this kind of thing from my day-to-day job. Also, there's no way to do merges and stuff from my phone, and I would need space/time to close the related issues, merge, and release a new tag. :P |
Finally, while this PR got a lot more attention, this is a dup. See you all on #154 :) |
hasSessionStore() method has been removed. In its place hasSession() method should be used.
Reference: laravel/framework@328e6cf