Skip to content
This repository has been archived by the owner on Jul 16, 2023. It is now read-only.

hasSessionStore has been removed #156

Closed
wants to merge 1 commit into from

Conversation

plmarcelo
Copy link

hasSessionStore() method has been removed. In its place hasSession() method should be used.

Reference: laravel/framework@328e6cf

hasSessionStore method has been removed. In its place hasSession() method shold be used. 

Reference: laravel/framework@328e6cf
@dalabarge
Copy link
Contributor

+1

2 similar comments
@mouhsinelonly
Copy link

+1

@globsecure
Copy link

+1

@cannap
Copy link

cannap commented Jan 17, 2014

+1

thx for this nice package

@dhardtke
Copy link

+1

5 similar comments
@lucasceballos
Copy link

+1

@ezynda3
Copy link

ezynda3 commented Jan 18, 2014

+1

@hskrasek
Copy link

+1

@vinicius73
Copy link

+1

@mgufrone
Copy link

+1

@jaketoolson
Copy link

+100

@matula
Copy link

matula commented Jan 20, 2014

+1

1 similar comment
@dwolfhub
Copy link

+1

@ejunker
Copy link

ejunker commented Jan 20, 2014

+1 In the meantime I've just adjusted my composer.json to lock my app on Laravel 4.1.16

"laravel/framework": "4.1.16",

@mbbender
Copy link

+1 2.4.x doesn't seem to work for me.

@EdgarsK
Copy link

EdgarsK commented Jan 22, 2014

+1

3 similar comments
@ghost
Copy link

ghost commented Jan 22, 2014

+1

@remluben
Copy link

+1

@RyanNielson
Copy link

+1

@warksit
Copy link
Contributor

warksit commented Jan 23, 2014

See #154

@markalanevans
Copy link

+1

@markalanevans
Copy link

2.4.* doesn't fix it.

@mishbah
Copy link

mishbah commented Jan 28, 2014

👍

@mgufrone
Copy link

wow, it's already 12 days. hope this commit will be evaluated soon. 👍

@cillosis
Copy link

+1

@grahammccarthy
Copy link

+1!!

@mishbah
Copy link

mishbah commented Jan 30, 2014

@mgufrone 👍

@markalanevans
Copy link

+1

@RyanNielson
Copy link

Any other contributors able to merge this and release? I'd like to be able to use the most recent Laravel with it. Currently I have to use 4.1.16 if I want to use Ardent without changing it myself. @laravelbook

@vinicius73
Copy link

@laravelbook this more than a few months without activities on github.
Do not know and do not know if something may have happened to him.
If this keeps up I think I will have to create a fork of ardent and work on it.

@mouhsinelonly
Copy link

@vinicius73 i think it's time for someone more interested in doing some free work to create a fork and i pledge to contribute as much as my time allows :)

@RyanNielson
Copy link

I mean the last update is only a month ago which isn't too bad to be honest. But a fork is always an option in the meantime.

@mouhsinelonly
Copy link

i guess we'll just wait and see ,and edit the source code manually until
@laravelbook get back ,probably he's just busy with work

2014-01-30 Ryan Nielson [email protected]:

I mean the last update is only a month ago which isn't too bad to be
honest. But a fork is always an option in the meantime.

Reply to this email directly or view it on GitHubhttps://github.com//pull/156#issuecomment-33700948
.

Mouhsine Bakhich * ,Developper Trans Gulf For Information Technology
Phone : *
**********
Email : [email protected]
Rue 41 N° 6 Av Sidi Said
biougra chtouka ait baha 87200
MA

@igorsantos07
Copy link
Member

Sorry boys, but first of all, laravelbook does not take care of this
anymore.

Second, I've been busy with my paid job and couldn't even stop at home to
see GitHub. I'm slowly getting back to life and seeing my emails slowly as
well.

Third, you don't need a fork. You can just learn to use Composer the right
way and discover:
A) how to use another branch as the main branch for a package
B) learn how to lock a version/commit, so other updates don't break your
current system

I'm going to merge this tonight or tomorrow. Please stop complaining or
revolting and bear with me. A couple of +1 is enough, but filling my inbox
with +1 won't make my time get free faster.

Finally, if there's anyone interested in entering the Ardent team, we can
talk about. I'm just afraid of making its code even worse, since there are
some parts that are currently quite fragile. We need more quality, not more
quantity ;)

Igor Santos
-- Desenvolvedor Web
[enviado do meu celular]
On Jan 30, 2014 2:28 PM, "mouhsinelonly" [email protected] wrote:

i guess we'll just wait and see ,and edit the source code manually until
@laravelbook get back ,probably he's just busy with work

2014-01-30 Ryan Nielson [email protected]:

I mean the last update is only a month ago which isn't too bad to be
honest. But a fork is always an option in the meantime.

Reply to this email directly or view it on GitHub<
https://github.com/laravelbook/ardent/pull/156#issuecomment-33700948>
.

Mouhsine Bakhich * ,Developper Trans Gulf For Information Technology
Phone : *
**********
Email : [email protected]
Rue 41 N° 6 Av Sidi Said
biougra chtouka ait baha 87200
MA

Reply to this email directly or view it on GitHubhttps://github.com//pull/156#issuecomment-33704430
.

@moura137
Copy link

moura137 commented Feb 5, 2014

In short, make a fork and change you without bothering to contribute.
@igorsantos07, it surprises me that answer.

@ejunker
Copy link

ejunker commented Feb 5, 2014

@igorsantos07 I appreciate your work on Ardent but 6 days ago you said you were going to merge this. It is a one line change and very low risk. Please merge.

@igorsantos07
Copy link
Member

I'm just saying that accepting a PR is not the only way to use the code, if
you read the your tool's manual.
I'm not expelling anyone from here.
Furthermore I got someone willing to help, and maybe he can give us a hand
in the next days :)
On Feb 5, 2014 3:21 PM, "Renato Moura" [email protected] wrote:

In short, make a fork and change you without bothering to contribute.
@igorsantos07 https://github.com/igorsantos07, it surprises me that
answer.

Reply to this email directly or view it on GitHubhttps://github.com//pull/156#issuecomment-34213493
.

@tbergeron
Copy link

I don't get what is going on, we're talking about merging one small line of code. Nothing fancy, and this would be greatly appreciated by the quite large amount of people who uses your code.

I took a second, forked your repo, fixed that line and simply added this to my composer.json file:

    "require": {
        "laravelbook/ardent": "master"
    },
    "repositories": [{
        "url": "https://github.com/tbergeron/ardent.git",
        "type": "git"
    }],

In a minute, Ardent was up and running. Why all of this? I mean all you have is click on a button.

Hope this temporarily help someone.

@RyanNielson
Copy link

Thanks for creating a temporary solution. I'd love to help on the project, and I've already contacted Igor a few days back. I haven't heard back yet, but I'm hoping I'm the person he's referring to in his last comment.

@igorsantos07
Copy link
Member

@tbergeron the short explanation is: I haven't touched my computer in ages, and I can't do this kind of thing from my day-to-day job. Also, there's no way to do merges and stuff from my phone, and I would need space/time to close the related issues, merge, and release a new tag. :P

@igorsantos07
Copy link
Member

Finally, while this PR got a lot more attention, this is a dup. See you all on #154 :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.