Skip to content
This repository has been archived by the owner on Jul 16, 2023. It is now read-only.

Test Coverage #55

Open
travisolbrich opened this issue Jun 26, 2013 · 7 comments
Open

Test Coverage #55

travisolbrich opened this issue Jun 26, 2013 · 7 comments
Assignees

Comments

@travisolbrich
Copy link
Contributor

I'd like to see some test coverage for Ardent. Has anyone written any tests for it already?

@modess
Copy link
Contributor

modess commented Jul 10, 2013

Since I'm using Ardent in a production environment I wouldn't mind writing tests that covers the class. But it would require some refactoring and that could perhaps be reviewed by the maintainer. So if @laravelbook is fine with that, I could get on it.

@laravelbook
Copy link
Collaborator

@modess Man you're a godsend! I've been extremely busy working on an enterprisey project (my dayjob) lately. It'd be nice to have you guys pick up the slack! ;) Please do go ahead with the test coverage. Thanks!

@mdwheele
Copy link
Contributor

I'm also available and interested to help out where needed. This is a great product that I'm getting a lot of use out of and I've really appreciated the work you've done on this so far @laravelbook

@igorsantos07
Copy link
Member

+1 with this, @modess and @mdwheele! I've felt the need of testing but although I know they are important, I'm not a great fan of writing tests :(

@igorsantos07
Copy link
Member

Ok, I'm really starting to see the need of tests to make the library maintainable. I'm willing to do some structural changes but tests are essential to make sure I'm not destroying the library after the changes.

However, I know nothing about mocking and stuff, so I may take some more time to write those things since I'll need to study some stuff first. But I'll work on this!

@ghost ghost assigned igorsantos07 Aug 2, 2013
@igorsantos07 igorsantos07 mentioned this issue Oct 13, 2013
@mdwheele
Copy link
Contributor

I'm in the process of writing tests and am actively avoiding making structural changes. This, of course, will affect how tidy the tests look but will be less invasive. I'll make sure to document well and keep it as organized as possible. We can always refactor later after the package has coverage.

@igorsantos07
Copy link
Member

This is exactly the idea, Dustin.

I tried to start testing some days ago but had little success, since I have
no experience with unit testing. As you've already started, do whatever you
think it's better and I'll try to help you once you send some PR (so at
least I'll have something to stare on and understand what else to do).

Igor Santos
Programador PHP / Ruby
igorsantos.com.br http://www.igorsantos.com.br || memelinks.com

On Wed, Oct 16, 2013 at 6:24 PM, Dustin Wheeler [email protected]:

I'm in the process of writing tests and am actively avoiding making
structural changes. This, of course, will affect how tidy the tests work
but will be less invasive. I'll make sure to document well and keep it as
organized as possible. We can always refactor later after the package has
coverage.


Reply to this email directly or view it on GitHubhttps://github.com//issues/55#issuecomment-26460048
.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants