Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minimum php version number #50

Merged
merged 2 commits into from
Oct 11, 2021
Merged

Conversation

mrbig00
Copy link
Contributor

@mrbig00 mrbig00 commented Oct 10, 2021

The arrow function in vendor/laracademy/generators/src/Commands/ModelFromTableCommand.php:316 requires min PHP 7.4

@daverogers
Copy link
Contributor

Good catch! Could you also update the README?

Copy link
Contributor Author

@mrbig00 mrbig00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed minimum PHP version in README

@michael-mcmullen michael-mcmullen merged commit 84331ce into laracademy:master Oct 11, 2021
daverogers added a commit to daverogers/generators that referenced this pull request Oct 13, 2021
commit 84331ce
Merge: 602f415 183c3ae
Author: Michael McMullen <[email protected]>
Date:   Mon Oct 11 14:00:00 2021 -0400

    Merge pull request laracademy#50 from mrbig00/patch-1

    Add minimum php version number

commit 602f415
Merge: 71e44bf f84b13e
Author: Michael McMullen <[email protected]>
Date:   Mon Oct 11 13:59:16 2021 -0400

    Merge pull request laracademy#51 from daverogers/cleanup-and-remove-all

    Cleanup and remove "all" option

commit 183c3ae
Author: Szántó Zoltán <[email protected]>
Date:   Mon Oct 11 16:57:42 2021 +0300

    Update minimum PHP version in README.md

commit f7309bd
Author: Szántó Zoltán <[email protected]>
Date:   Sun Oct 10 18:32:41 2021 +0300

    Add minimum php version number
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants