Wrap selected text with brackets/quotes #1452
Conversation
| @@ -210,7 +233,7 @@ impl Editor { | |||
| .map(|(idx, content)| { | |||
| let region = &selection.regions()[*idx]; | |||
| ( | |||
| Selection::region(region.start, region.end), | |||
| Selection::region(region.max(), region.max()), | |||
There was a problem hiding this comment.
not sure whether this will break something, but I feel like it makes a bit more sense...
edits after should be applied to the end of the selection right?
There was a problem hiding this comment.
This will be incorrect if the selection isn't a caret.
There was a problem hiding this comment.
forgot to ask, when will the selection not be a caret?
There was a problem hiding this comment.
I can't workout what I'm missing here.
for edits_after we never really want to replace the text? I don't think.
Its only used for this + matching pairs (i.e. type "(" it automatically closes it) + I can't think of when this would be wrong
Codecov Report
@@ Coverage Diff @@
## master #1452 +/- ##
======================================
Coverage 6.63% 6.64%
======================================
Files 125 125
Lines 51326 51342 +16
======================================
+ Hits 3406 3411 +5
- Misses 47920 47931 +11
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
lapce-core/src/editor.rs
Outdated
| // wrap the text with that char and its corresponding closing pair | ||
| if region.start != region.end | ||
| && (matching_pair_type.is_some() || c == '"' || c == '\'') | ||
| && ((matching_pair_type.unwrap_or(false)) |
There was a problem hiding this comment.
You can replace
(matching_pair_type.is_some() || c == '"' || c == '\'')
&& ((matching_pair_type.unwrap_or(false))
|| c == '"'
|| c == '\'')
with
matching_pair_type == Some(true) || c == '"' || == '\''
camc314
force-pushed
the
cam/dev/wrap-selected-text
branch
from
42338a3 to
91935c2
Compare
when text is selected, and [, (, {, ", ' is typed, it wrapped the selected text with that character pair
Screen.Recording.2022-10-07.at.17.36.32.mov