feat(adapter-ui): surface proposal validation findings in the review UI#489
Conversation
Proposal-validation Phase 3 (compatibility / breaking-reference checks) produces warnings/errors on a proposal's validationResult, but the review UI never showed them — a reviewer could not see that a proposal would break existing references. Add a read-only ProposalValidationFindings component (+ pure, tested helpers): - Renders each non-skipped phase's errors (blocking, destructive styling) and warnings (advisory, amber styling) with code + message + optional target/field. - Emphasizes Phase 3 (compatibility): distinct icon, dedicated title, sorted first. - Defensive against missing/partial validationResult; renders nothing when clean. - Mounted on the proposal review surface (proposal-review-demo) next to the existing impact preview, driven by the same fixture switcher. Extracts the inline validationResult shape on Proposal into reusable exported types (ProposalValidationFinding/Phase/Result). Purely presentational — never submits/approves/applies. ui imports no server/core runtime. Pre-analysis (dedup/impact) is not plumbed to the client yet and is out of scope. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Warning Review limit reached
More reviews will be available in 6 minutes and 44 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (8)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces the ProposalValidationFindings component to display validation findings in the proposal review UI, specifically highlighting Phase 3 compatibility and breaking-reference checks. It also extracts validation types for reusability, adds comprehensive unit tests for helper functions, and updates localization files. The review feedback suggests improving the component by removing a redundant hasAnyFindings check and its unused import, and ensuring unique React keys by appending the map index to prevent duplicate key warnings.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
…dundant hasAnyFindings check
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
1 participant
What & why
Proposal-validation Phase 3 (compatibility / breaking-reference checks) (#487) produces warnings/errors on a proposal's
validationResult, but the review UI never displayed them — a reviewer could not see that a proposal would break existing references. This surfaces them.Change
New read-only
ProposalValidationFindingscomponent + pure, tested helpers:code+message+ optionaltarget/field.validationResult(returns[]/zeros, never throws); renders nothing when clean.proposal-review-demo) beside the existing impact preview, driven by the same fixture switcher.Extracts the inline
validationResultshape onProposalinto reusable exported types (ProposalValidationFinding/Phase/Result).Boundary
Purely presentational — never submits/approves/applies/commits.
uiimports no server/core runtime (the validation-result type is mirrored locally in the client lib). Pre-analysis (dedup/impact) is not yet plumbed to the client — verified, left out of scope (no server plumbing added).Review
Cross-model reviewed (codex): clean, no actionable findings.
Tests
proposal-validation-findings.test.ts— 19bun:testassertions over the helpers (selectPhasesWithFindingsnull/partial defensiveness, skipped/clean exclusion, Phase-3-first sort;countFindingscross-phase totals + defensive zeros;hasAnyFindings). Helpers are logic-only (the package has no jsdom/happy-dom render infra — consistent with sibling tests).Gates
bun run check,bun run typecheck, fullbun run test(batched) all green.🤖 Generated with Claude Code