Test PHP 7.2 #6
Merged
Test PHP 7.2 #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use proper autoloading Fix whitelist Use class for PHP 7 and define phpunit version Fix composer.json Use required phpunit
lanthaler
reviewed
Aug 16, 2018
composer.json
Outdated
| "psr-0": { "ML\\IRI": "" } | ||
| "classmap": ["src/"], | ||
| "psr-4": { | ||
| "ML\\IRI\\": "src/", |
There was a problem hiding this comment.
Any reason to not simply point this to "", get rid of the second declaration and leave the IRI.php file where it currently is?
There was a problem hiding this comment.
Fair point @lanthaler, this is the standard I've used and I get scared to deviate but it doesn't seem like its necessary.
|
Thanks a lot for this Jared. Feel free to remove the |
|
I realize the code-coverage is wrong now, I'll figure that out and add another commit here. |
|
Thanks for these changes Jared |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought because JsonLD relies on this (and I submitted lanthaler/JsonLD#92) I should add a test for PHP 7.2 here as well.
That brought up some issues because Travis has changed and this repository seemed to fail tests that previously it passed.
I have done some moving of pieces to get all the test working again.
I didn't but I think you can remove this line as there is no
http_test_serverinstalled so this does nothing.I hope I haven't overstepped my bounds here.
cheers