Add use_metadata context manager (fixes #745).
#746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like there is an issue with uploading results to codecov. Do you know why that might be, @lanpa? |
|
Sorry for the late reply. For the python 3.11 error, I might have misconfigured the coverage test token. Checking it out now. |
|
Hi, I have fixed the coverage test, and the following workflow is failed. Would you take a look? |
|
Thanks for the commit to fix the codecov upload. Tests now pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
use_metadatacontext manager to specify default values forglobal_stepandwalltime. There are some usage examples in the tests, and I've updated the demo file to illustrate the use of the context manager.I didn't quite know the right level of the codebase to add the state to. For now, I settled on the
FileWriterclass because alladd_*seem to go through theadd_eventmethod of theFileWriterso it was easy to inject the defaults there. TheSummaryWriterclass has a convenience context manager method which just wraps the associatedFileWriter.I also dropped one duplicate test definition
test_flushwhile adding the tests.This PR currently does not support the comet logger because I wasn't quite sure about the right implementation. Comments welcome.