Fix #108 (#560)

^Q^
lanpa · Feb 26, 2020 · e56a07a · e56a07a
1 parent b59430b
commit e56a07a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/tensorboardX/event_file_writer.py b/tensorboardX/event_file_writer.py
@@ -157,6 +157,8 @@ def close(self):
             self._worker.stop()
             self._ev_writer.close()
             self._event_queue.close()
+            self._event_queue = None  # this is critical
+            self._worker = None  # this is critical too
             self._closed = True
 
 

diff --git a/tests/test_summary_writer.py b/tests/test_summary_writer.py
@@ -16,14 +16,9 @@ def test_summary_writer_backcomapt(self):
     def test_summary_writer_close(self):
         # Opening and closing SummaryWriter a lot should not run into
         # OSError: [Errno 24] Too many open files
-        passed = True
-        try:
+        for i in range(1000):
             writer = SummaryWriter()
             writer.close()
-        except OSError:
-            passed = False
-
-        assert passed
 
     def test_windowsPath(self):
         dummyPath = "C:\\Downloads\\fjoweifj02utj43tj430"