Added configs for hiding error annotations or diagnostics

lannonbr · Sep 14, 2018 · d7099c0 · d7099c0
1 parent 67587e6
commit d7099c0
Show file tree

Hide file tree

Showing 5 changed files with 23 additions and 7 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,8 @@
 # Changelog
 
+## 0.8.1 - Sep 13, 2018
+- [Hotfix] Added settings to hide either of the diagnostics or error annotations
+
 ## 0.8.0 - Sep 13, 2018
 - [Feature] Invalid parameters in JS will now appear in the Problems panel
 

diff --git a/README.md b/README.md
@@ -17,6 +17,8 @@ There currently is a few configurable settings in the extension
 |-------|------------|---------|
 | `jsannotations.enabled`  | Enable JS Annotations | true |
 | `jsannotations.hideIfEqual` | Hide annotation if argument name matches parameter name | true |
+| `jsannotations.hideInvalidAnnotation` | Hide annotations for invalid params | true |
+| `jsannotations.hideDiagnostics` | Hide red squiggles under invalid parameters | false |
 | `jsannotations.fontWeight` | Annotation styling of font-weight CSS property | "400" |
 | `jsannotations.fontStyle` | Hide annotation if argument name matches parameter name | "italic" |
 

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -2,7 +2,7 @@
   "name": "vscode-js-annotations",
   "displayName": "JS Parameter Annotations",
   "description": "Annotations for parameters in your JS / TS Files to mimic named parameters",
-  "version": "0.8.0",
+  "version": "0.8.1",
   "publisher": "lannonbr",
   "engines": {
     "vscode": "^1.25.0"
@@ -39,6 +39,16 @@
             "description": "Enable JS Annotations",
             "default": true
           },
+          "jsannotations.hideInvalidAnnotation": {
+            "type": "boolean",
+            "description": "Hide annotations for invalid params",
+            "default": true
+          },
+          "jsannotations.hideDiagnostics": {
+            "type": "boolean",
+            "description": "Hide red squiggles under invalid parameters",
+            "default": false
+          },
           "jsannotations.hideIfEqual": {
             "type": "boolean",
             "description": "Hide annotation if argument name matches parameter name",

diff --git a/src/decorator.ts b/src/decorator.ts
@@ -49,15 +49,16 @@ export async function decorateFunctionCall(currentEditor: vscode.TextEditor, doc
             decoration = Annotations.paramAnnotation(paramList[restParamIdx] + `[${idx - restParamIdx}]: `, currentArgRange);
           } else {
             if (idx >= paramList.length) {
-              const errorDecoration = Annotations.errorParamAnnotation(currentArgRange);
-
-              if (currentEditor.document.languageId === "javascript") {
-
+              if (currentEditor.document.languageId === "javascript" && vscode.workspace.getConfiguration("jsannotations").get("hideDiagnostics") === false) {
                 const diag = new vscode.Diagnostic(currentArgRange, "[JS Param Annotations] Invalid parameter", vscode.DiagnosticSeverity.Error);
                 diagnostics.push(diag);
               }
 
-              errDecArray.push(errorDecoration);
+              if (vscode.workspace.getConfiguration("jsannotations").get("hideInvalidAnnotation") === false) {
+                const errorDecoration = Annotations.errorParamAnnotation(currentArgRange);
+                errDecArray.push(errorDecoration);
+              }
+
               continue;
             }
             decoration = Annotations.paramAnnotation(paramList[idx] + ": ", currentArgRange);