Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collisions with uneven weights "works" but gives wrong values #137

Open
rfbird opened this issue Jan 5, 2021 · 1 comment
Open

Collisions with uneven weights "works" but gives wrong values #137

rfbird opened this issue Jan 5, 2021 · 1 comment
Assignees

Comments

@rfbird
Copy link
Contributor

rfbird commented Jan 5, 2021

Right now the TA collisions accepts a users requests to run collisions on species with different weights. This runs but does not give a correct science answer as it is not supported by the current formulation of the TA operator

There is theory work by Miller and Combi that addresses this, but needs to be implemented

For now we can just detect the bad input and error out to avoid the impression that the code is doing the right thing when it's not

@rfbird rfbird self-assigned this Jan 5, 2021
rfbird added a commit that referenced this issue Jan 5, 2021
rfbird added a commit that referenced this issue Jan 6, 2021
@rfbird
Copy link
Contributor Author

rfbird commented Jan 25, 2021

This now tries to give a warning if it can detect the issue, but is not robust

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant