Enable user boundary conditions for particles #655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brryan
changed the title
brryan
changed the title
brryan
changed the title
Yurlungur
approved these changes
Mar 3, 2022
lroberts36
approved these changes
Mar 16, 2022
Comment on lines
+601
to
+604
| if (start_index < 0) { | ||
| start_index = -1; | ||
| break; | ||
| } |
There was a problem hiding this comment.
Are these changes related to setting the user boundary conditions or is this a separate fix?
There was a problem hiding this comment.
This is a separate fix that came up while I was testing this PR -- for some pools of particles (in particular when using very few particles) one could end up trying to index into an array with start_index where start_index was -1 which would segfault.
pgrete
requested changes
Mar 24, 2022
@pgrete I added an |
pgrete
approved these changes
Apr 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Particle swarms are intended to support user-provided boundary conditions, but there was a bit of connectivity missing between the user-side application inputs and the Swarms themselves; specifically, we were checking for correct particle boundaries before user boundaries could be set.
On an earlier attempt at making this change I noticed that
InitUserMeshDatais (I think) not very useful right now because application-specified functions can't access theMeshvariables. In particular, I need to be able to setSwarmboundary conditions to application-specificuservalues at this point in the mesh setup. I don't useInitUserMeshDatahere but I assume we want this change?All this PR does is add the
thispointer to theMeshcalls toInitUserMeshData.PR Checklist