MeshBlock Cleanup and Smart Backpointers. Resolves #306. #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… constructors. Factory method necessary to implement back pointers as weak.
Yurlungur
requested review from
nmsriram,
AndrewGaspar,
forrestglines,
jdolence and
pgrete
AndrewGaspar
suggested changes
Sep 21, 2020
|
@AndrewGaspar I believe all your requested changes have been implemented. |
AndrewGaspar
approved these changes
Sep 23, 2020
|
@pgrete @forrestglines can I get one more approval from the Athena team? |
Yeah. I know. |
pgrete
reviewed
Sep 25, 2020
Co-authored-by: Philipp Grete <[email protected]>
Co-authored-by: Philipp Grete <[email protected]>
pgrete
approved these changes
Sep 25, 2020
Codecov Report
@@ Coverage Diff @@
## develop #307 +/- ##
===========================================
- Coverage 56.71% 56.69% -0.03%
===========================================
Files 99 99
Lines 10441 10445 +4
===========================================
Hits 5922 5922
- Misses 4519 4523 +4
Continue to review full report at Codecov.
|
|
Pulling the trigger. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
As discussed in #306 and #303, smart pointers to meshblocks means we can use them elsewhere in the code, for example, with weak back pointers. This Implements that change.
In addition, I substantially clean up the MeshBlock class. I noticed that all three constructors had the same functionality copy-pasted. I therefore removed all but one of them. I also changed the constructors to a factory method. This was necessary because of a subtlety with smart pointers. You cannot create a weak pointer to an object in its own constructor.
PR Checklist