Gray vs multigroup #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/jaybenne/sourcing.cpp
Outdated
| for (int n = 1; n < n_nubinsd; n++) { | ||
| const Real nu = std::exp(std::log(numind) + (n + 0.5) * dlnu); | ||
| vmesh(b, fj::emission_cdf(n), k, j, i) = | ||
| opac->EmissivityPerNu(rho, temp, nu) + |
There was a problem hiding this comment.
Quick question on the units here - from the singularity-opac README, it looks like EmissivityPerNu returns units as energy density per time per frequency. Should there be a dnu multiplying opac->EmissivityPerNu(rho, temp, nu) here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
We want to have both gray and multigroup modes
One question is whether this should be a continuous energy or a multigroup representation.
Singularity-opacright now always accepts a continuous frequency argument; maybe this needs to be expanded upon with a multigroup integer index variant. Should multigroup support nonuniformly binned data?Description of Changes
jaybennepackage initialization into gray vs mg depending on which singularity variants are presentChecklist