Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor find, logger, readers, wildfire/pennant examples, sqlite tests #138

Closed
Vedant1 opened this issue Feb 8, 2025 · 0 comments · Fixed by #139
Closed

Refactor find, logger, readers, wildfire/pennant examples, sqlite tests #138

Vedant1 opened this issue Feb 8, 2025 · 0 comments · Fixed by #139
Assignees

Comments

@Vedant1
Copy link
Collaborator

Vedant1 commented Feb 8, 2025

  • Find should have standardized return object from sqlite: ValueObject
  • Unique find functions for table, col, or cell match
  • a find all function which collates all these individual searches into one large list
  • any find function should only access first backend loaded in
  • update find test functions in test_sqlite.py
  • logger now uses levels 0, 1, 2 for verbosity of print statements
  • all backends/readers/writers should return error messages instead of printing to console
    • for the purpose of logger catching all error messages
  • standardize any mention of a "run table" in DSI to be a runTable object: whether a variable or creating it in a backend
  • update error catching for any core functions to ensure all inputs were correct
  • create a close function which closes all backends/plugins and clears the abstraction
  • get/inspect artifacts should only access first backend loaded in
  • read artifacts should only access first back-READ backend loaded in
  • create a reader specific to wildfire data and any post-process data
  • wildfire reader creates manual sim table where each row of data is its own simulation
  • update error catching for table plot plugin writer
  • csv and table plot writer take in optional argument of a list of column names
  • update wildfire and pennant examples to use the wildfire reader with a manual simulation table
  • update descriptions of all relevant functions in core/sqlite/file_reader/file_writer/metadata
@Vedant1 Vedant1 self-assigned this Feb 8, 2025
@jpulidojr jpulidojr linked a pull request Mar 1, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant