Draft: jtlaune/nu-disk #27
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brryan
reviewed
Dec 10, 2024
jtlaune
commented
Dec 10, 2024
| gvel1 = ArtemisUtils::VDot(vcyl, ex1); | ||
| gvel2 = ArtemisUtils::VDot(vcyl, ex2); | ||
| gvel3 = ArtemisUtils::VDot(vcyl, ex3); | ||
| } |
There was a problem hiding this comment.
Compile errors were from this bracket missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Adding in my initial conditions, boundary conditions, & damping zones for a vertically stratified constant nu disk.
Description of Changes
I have added a new problem generator file, nu_disk.hpp and modified drag.cpp/hpp to be consistent. I think going forward I need to add input parameters to switch on the behavior in drag, as this modifies the core functionality as is.
Submitting as a draft because I'm getting compile errors from pgen.hpp and problem_modifier.hpp when I try to add in a new pgen file.
Checklist