Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Danielconda #247

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Danielconda #247

wants to merge 2 commits into from

Conversation

djdunning
Copy link
Collaborator

Description

Most things stayed the same, copied over extra anaconda package recipes from FierroMechanics repository. Added publishing actions, won't appear until it's part of main.

Fixes any of the anaconda build issues, especially with the GPU versions. Fix won't go through until Matar CUDA version is published and linked to

Same PR as before with 'Daniel' branch but I messed up that branch so the PR isn't relevant. Trying to get all my changes through here.

Working on fixing CUDA conda builds

Type of change

Please select all relevant options

  • [ x] New feature (non-breaking change which adds functionality)
  • [ x] Bug fix (non-breaking change which fixes an issue)
  • Formatting and/or style fixes
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Test A : local tests on Mac and Linux HPC machine
  • Test B :

Test Configuration:

  • OS version: linux, macOS
  • Hardware: Mac m2, skylake-gold, V100
  • Compiler: all compilers tried by conda

Checklist:

  • My code follows the style guidelines of this project
  • [x ] I have performed a self-review of my code
  • [x ] I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • [ x] My changes generate no new warnings
  • [x ] The code builds from scratch with my new changes
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • [ x] Any dependent changes have been merged and published in downstream modules

@djdunning
Copy link
Collaborator Author

Cuda builds won't work yet, so they don't get published, but that's why they "fail", because it keeps trying to run the Mac ones.
Voxelizer won't work until these changes get PR'ed into the main branch, needed to change it's CMakeLists.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant