Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to issues with PVTU writer 12/24 #245

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

elieberman3
Copy link
Collaborator

Description

Fixed issues with PVTU writer associated with running on GPUs. Also moved the t=0 viz output code to after many inits to ensure fields are defined.

Adapted GPU incompatible variables to local dual arrays for use within FOR_ALL.
Converted FOR_ALL's within writer to FOR_ALL_CLASS's to use non-local variables correctly.

Type of change

Please select all relevant options

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Formatting and/or style fixes
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Ran code on GPUs without crashing at viz output step due to memory issues.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • The code builds from scratch with my new changes
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Collaborator

@jacob-moore22 jacob-moore22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch on that FOR_ALL_CLASS. Thanks for getting this fix in so quickly. LGTM.

@elieberman3
Copy link
Collaborator Author

Updated code to be thread safe and produce correct output if you want to look again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants