Skip to content

Fix handling of {Primal,Dual}Status#250

Merged
odow merged 4 commits intomasterfrom
od/fix-status
Aug 17, 2022
Merged

Fix handling of {Primal,Dual}Status#250
odow merged 4 commits intomasterfrom
od/fix-status

Conversation

@odow
Copy link
Copy Markdown
Collaborator

@odow odow commented Aug 14, 2022

Closes #249

@odow
Copy link
Copy Markdown
Collaborator Author

odow commented Aug 14, 2022

The DualStatus thing is another surprise. I think I recall people trying to use Juniper with SDDP.jl and getting weird errors, so perhaps this was the reason.

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 14, 2022

Codecov Report

Merging #250 (f99ab61) into master (053661e) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #250      +/-   ##
==========================================
- Coverage   91.81%   91.79%   -0.03%     
==========================================
  Files          20       20              
  Lines        2015     2010       -5     
==========================================
- Hits         1850     1845       -5     
  Misses        165      165              
Impacted Files Coverage Δ
src/MOI_wrapper/results.jl 86.84% <100.00%> (-1.53%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Wikunia
Copy link
Copy Markdown
Member

Wikunia commented Aug 17, 2022

I'm happy to get this merged is there anything you would like to add or can this be merged @odow ?

@odow odow merged commit 2ab639e into master Aug 17, 2022
@odow odow deleted the od/fix-status branch August 17, 2022 21:38
@ccoffrin
Copy link
Copy Markdown
Member

@odow, also should we add a note to the changelog?

@odow
Copy link
Copy Markdown
Collaborator Author

odow commented Aug 18, 2022

Yes, I'll add and prep a new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect PrimalStatus if termination is not optimal

3 participants