Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: (#9089 followup) fix storage factory constructor #9609

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

bowenliang123
Copy link
Contributor

@bowenliang123 bowenliang123 commented Oct 22, 2024

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

  • fixes unused required parameter flask app in storage factories:
    image

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Oct 22, 2024
@bowenliang123
Copy link
Contributor Author

cc @laipz8200

@bowenliang123 bowenliang123 changed the title chore: fix storage factory constructor chore: (#9089 followup) fix storage factory constructor Oct 22, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 22, 2024
@laipz8200 laipz8200 merged commit d170d78 into langgenius:main Oct 22, 2024
6 checks passed
@bowenliang123 bowenliang123 deleted the fix-storage-factory branch October 22, 2024 05:03
laipz8200 added a commit that referenced this pull request Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants