Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/firefox overflow error #9438

Merged
merged 6 commits into from
Oct 17, 2024
Merged

Fix/firefox overflow error #9438

merged 6 commits into from
Oct 17, 2024

Conversation

WTW0313
Copy link
Contributor

@WTW0313 WTW0313 commented Oct 17, 2024

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. Close issue syntax: Fixes #<issue number>, see documentation for more details.

Fixes

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 🐞 bug Something isn't working labels Oct 17, 2024
@crazywoola
Copy link
Member

Can you attach a screenshot?

@WTW0313
Copy link
Contributor Author

WTW0313 commented Oct 17, 2024

workflow panel overflow error
image
model parameter modal overflow error
image

@WTW0313 WTW0313 marked this pull request as draft October 17, 2024 06:16
@WTW0313 WTW0313 marked this pull request as ready for review October 17, 2024 07:42
@dosubot dosubot bot added the ☕️ typescript Pull request that update TypeScript code. label Oct 17, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 17, 2024
@crazywoola crazywoola merged commit f447ee7 into main Oct 17, 2024
7 checks passed
@crazywoola crazywoola deleted the fix/firefox-overflow-error branch October 17, 2024 07:54
lau-td pushed a commit to heydevs-io/dify that referenced this pull request Oct 23, 2024
idonotknow pushed a commit to AceDataCloud/Dify that referenced this pull request Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files. ☕️ typescript Pull request that update TypeScript code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants