Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected type annotation to "Any" from "any" all files in "model_providers" folder #9135

Merged
merged 4 commits into from
Oct 10, 2024

Conversation

ronaksingh27
Copy link
Contributor

@ronaksingh27 ronaksingh27 commented Oct 9, 2024

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. Close issue syntax: Fixes #<issue number>, see documentation for more details.

Fixes #9080

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 🐍 python labels Oct 9, 2024
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Oct 9, 2024
@ronaksingh27 ronaksingh27 changed the title "any -> Any" in tts_model.py "any -> Any" standardised type annotation to "Any" from "any" all files in "model_providers" folder Oct 9, 2024
@ronaksingh27 ronaksingh27 changed the title "any -> Any" standardised type annotation to "Any" from "any" all files in "model_providers" folder standardised type annotation to "Any" from "any" all files in "model_providers" folder Oct 9, 2024
@ronaksingh27 ronaksingh27 changed the title standardised type annotation to "Any" from "any" all files in "model_providers" folder Corrected type annotation to "Any" from "any" all files in "model_providers" folder Oct 9, 2024
@laipz8200 laipz8200 self-requested a review October 10, 2024 01:29
@ronaksingh27
Copy link
Contributor Author

@laipz8200 I have made corrections to the files to address the spacing issues. Please let me know if there's anything else you'd like me to adjust

Copy link
Member

@laipz8200 laipz8200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 10, 2024
@laipz8200 laipz8200 merged commit 62051d5 into langgenius:main Oct 10, 2024
6 checks passed
lau-td pushed a commit to heydevs-io/dify that referenced this pull request Oct 23, 2024
idonotknow pushed a commit to AceDataCloud/Dify that referenced this pull request Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect any Type Annotations in the Codebase
2 participants