add generate conversation name error log #9117
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Important
Please review the checklist below before submitting your pull request.
dev/reformat
(backend) andcd web && npx lint-staged
(frontend) to appease the lint godsDescription
This pull request addresses an issue where exceptions during conversation name generation were being silently caught and ignored. This made it difficult to identify and diagnose problems in this process. The change implements proper exception logging to improve visibility and debugging capabilities.
The main change is in the
_generate_conversation_name_worker
method of theMessageCycleManage
class. We've replaced the genericexcept: pass
block with a specific exception catch that logs the error details.Fixes #[Issue Number]
Type of Change
Testing Instructions
To verify this change, please follow these steps:
LLMGenerator.generate_conversation_name
method (e.g., by passing invalid parameters)