Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add generate conversation name error log #9117

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

pinsily
Copy link
Contributor

@pinsily pinsily commented Oct 9, 2024

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

This pull request addresses an issue where exceptions during conversation name generation were being silently caught and ignored. This made it difficult to identify and diagnose problems in this process. The change implements proper exception logging to improve visibility and debugging capabilities.

The main change is in the _generate_conversation_name_worker method of the MessageCycleManage class. We've replaced the generic except: pass block with a specific exception catch that logs the error details.

Fixes #[Issue Number]

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

To verify this change, please follow these steps:

  • Run the application in a development environment
  • Trigger a conversation name generation process
  • Intentionally cause an error in the LLMGenerator.generate_conversation_name method (e.g., by passing invalid parameters)
  • Check the application logs for an error message starting with "generate conversate name failed: " followed by exception details
  • Verify that the application continues to function normally despite the error in name generation

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 🐞 bug Something isn't working labels Oct 9, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 9, 2024
@crazywoola crazywoola merged commit 7a1da24 into langgenius:main Oct 9, 2024
6 checks passed
@crazywoola crazywoola mentioned this pull request Oct 12, 2024
12 tasks
lau-td pushed a commit to heydevs-io/dify that referenced this pull request Oct 23, 2024
idonotknow pushed a commit to AceDataCloud/Dify that referenced this pull request Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants