Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: disable chat service API passing parent_message_id #8984

Merged
merged 10 commits into from
Oct 14, 2024

Conversation

xuzuodong
Copy link
Contributor

@xuzuodong xuzuodong commented Oct 2, 2024

Reimplementation of #8965, fixes #8910, but using a better way to be compatible.

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. Close issue syntax: Fixes #<issue number>, see documentation for more details.

Fixes

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Oct 2, 2024
@xuzuodong xuzuodong changed the title Chatting via service API force UUID_NIL as parent_message_id Chat via service API forcing parent_message_id to be UUID_NIL Oct 2, 2024
@xuzuodong xuzuodong marked this pull request as draft October 10, 2024 16:28
@xuzuodong xuzuodong marked this pull request as ready for review October 12, 2024 01:43
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Oct 12, 2024
@xuzuodong xuzuodong changed the title Chat via service API forcing parent_message_id to be UUID_NIL chore: disable chat service API passing parent_message_id Oct 12, 2024
Copy link
Collaborator

@laipz8200 laipz8200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you :)

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 12, 2024
@laipz8200 laipz8200 merged commit fa47f0c into langgenius:main Oct 14, 2024
6 checks passed
@laipz8200 laipz8200 changed the title chore: disable chat service API passing parent_message_id feat: disable chat service API passing parent_message_id Oct 21, 2024
lau-td pushed a commit to heydevs-io/dify that referenced this pull request Oct 23, 2024
@glacierck
Copy link

glacierck commented Oct 31, 2024

@laipz8200 @xuzuodong How to achieve 'regeneration' of historical information if this parameter is lost?
image

How can I use the API to modify historical conversation messages without this parameter? @AllenWriter all
Please restore the use of 'parent_message_id'!

idonotknow pushed a commit to AceDataCloud/Dify that referenced this pull request Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DifY API is not bringing the conversation/session history
3 participants