Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: sort Gemini models #8951

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

CXwudi
Copy link
Contributor

@CXwudi CXwudi commented Sep 30, 2024

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas (no code changes)
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods (no code changes)

Description

This little PR simply just sorts the Gemini model list with a sensible order.
image

Now the list looks more appealing and straightforward compared to before.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • No test is required except checking visually

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Sep 30, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 1, 2024
@crazywoola crazywoola merged commit 0d84221 into langgenius:main Oct 1, 2024
6 checks passed
@CXwudi CXwudi deleted the chore/sort-gemini-models branch October 1, 2024 04:09
aloababa pushed a commit to iguanesolutions/dify that referenced this pull request Oct 2, 2024
cuiks pushed a commit to cuiks/dify that referenced this pull request Oct 8, 2024
lau-td pushed a commit to heydevs-io/dify that referenced this pull request Oct 23, 2024
idonotknow pushed a commit to AceDataCloud/Dify that referenced this pull request Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants