Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tts (blocking call) #6869

Merged
merged 2 commits into from
Aug 1, 2024

Conversation

ic-xu
Copy link
Contributor

@ic-xu ic-xu commented Aug 1, 2024

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

Remove the code block that contains the blocking logic in TTS, this change will only affect the subsequent verification calls for the added model from this point on.

Fixes

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Just verify whether the TTS model can be added normally.

  • Test A
  • Test B

ic-xu added 2 commits August 1, 2024 13:11
…his change will only affect the subsequent verification calls for the added model from this point on.
…his change will only affect the subsequent verification calls for the added model from this point on.
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. 🐞 bug Something isn't working labels Aug 1, 2024
@crazywoola crazywoola requested a review from laipz8200 August 1, 2024 05:19
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 1, 2024
@crazywoola crazywoola merged commit a9cd6df into langgenius:main Aug 1, 2024
5 checks passed
@takatost takatost mentioned this pull request Aug 5, 2024
cuiks pushed a commit to cuiks/dify that referenced this pull request Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants